On 16. 11. 20 8:55, Michael Tretter wrote: > Currently, xvcu_pll_set_rate configures the PLL to a clock rate that is > pre-calculated when probing the driver. To still make the clock > framework aware of the PLL and to allow to configure other clocks based > on the PLL rate, register the PLL as a fixed rate clock. > > Signed-off-by: Michael Tretter <m.tretter@xxxxxxxxxxxxxx> > --- > drivers/soc/xilinx/Kconfig | 2 +- > drivers/soc/xilinx/xlnx_vcu.c | 17 ++++++++++++++++- > 2 files changed, 17 insertions(+), 2 deletions(-) > > diff --git a/drivers/soc/xilinx/Kconfig b/drivers/soc/xilinx/Kconfig > index 0b1708dae361..9fe703772e5a 100644 > --- a/drivers/soc/xilinx/Kconfig > +++ b/drivers/soc/xilinx/Kconfig > @@ -3,7 +3,7 @@ menu "Xilinx SoC drivers" > > config XILINX_VCU > tristate "Xilinx VCU logicoreIP Init" > - depends on HAS_IOMEM > + depends on HAS_IOMEM && COMMON_CLK > select REGMAP_MMIO > help > Provides the driver to enable and disable the isolation between the > diff --git a/drivers/soc/xilinx/xlnx_vcu.c b/drivers/soc/xilinx/xlnx_vcu.c > index 34f3299afc0d..725e646aa726 100644 > --- a/drivers/soc/xilinx/xlnx_vcu.c > +++ b/drivers/soc/xilinx/xlnx_vcu.c > @@ -7,6 +7,7 @@ > * Contacts Dhaval Shah <dshah@xxxxxxxxxx> > */ > #include <linux/clk.h> > +#include <linux/clk-provider.h> > #include <linux/device.h> > #include <linux/errno.h> > #include <linux/io.h> > @@ -80,6 +81,7 @@ struct xvcu_device { > struct clk *aclk; > struct regmap *logicore_reg_ba; > void __iomem *vcu_slcr_ba; > + struct clk_hw *pll; this is introducing kernel-doc warning. Please describe it there. M