On Sun, Jun 22, 2014 at 10:04:58AM +0100, Robert Jarzmik wrote:
> Add documentation for device-tree binding of arm PXA 27x udc (usb
> device) driver.
>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@xxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx
>
> ---
> Since V1: change OF id mrvl,pxa27x_udc -> marvell,pxa27x-udc
> This is a consequence of other DT reviews on the marvell
> namings.
> ---
> Documentation/devicetree/bindings/usb/pxa-usb.txt | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/pxa-usb.txt b/Documentation/devicetree/bindings/usb/pxa-usb.txt
> index 79729a9..0e4863f 100644
> --- a/Documentation/devicetree/bindings/usb/pxa-usb.txt
> +++ b/Documentation/devicetree/bindings/usb/pxa-usb.txt
> @@ -29,3 +29,23 @@ Example:
> marvell,port-mode = <2>; /* PMM_GLOBAL_MODE */
> };
>
> +UDC
> +
> +Required properties:
> + - compatible: Should be "marvell,pxa27x-udc" for USB controllers
> + used in device mode.
We typically don't like wildcard compatible strings in DT.
> +
> +Optional properties:
> + - "udc-pullup-gpio" - gpio activated to control the USB D+ pullup.
> + - "udc-pullup-gpio-inverted" - boolean inverting gpio pullup logic.
Use the GPIO bindings.
> +
> +Example:
> +
> + pxa27x_udc: udc@40600000 {
> + compatible = "marvell,pxa27x-udc";
> + reg = <0x40600000 0x10000>;
> + interrupts = <11>;
> + clocks = <&pxa2xx_clks 11>;
> + clock-names = "pxa27x-udc";
Neither of these were mentioned above.
The name of the clock input doesn't make sense.
Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
