On 01/12/2020 14:13, Jonathan Neuschäfer wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Tue, Dec 01, 2020 at 11:02:42AM +0000, conor.dooley@xxxxxxxxxxxxx wrote: > > From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > > > This driver adds support for the single mailbox channel of the MSS > > system controller on the Microchip PolarFire SoC. > > Out of my curiosity: What is MSS? Is it the Microprocessor Subsystem in > the SoC? > yes, it is the microprocessor subsystem > (It isn't quite clear from the PolarFire documentation I could find) > > > > > Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > --- > [...] > > +config MPFS_MBOX > > + tristate "MPFS Mailbox" > > "MPFS" in the title seems (to me) a bit too obscure for the uninitiated. > Perhaps you could use something slightly longer that mentions Microchip > and/or the PolarFire series? Sure. MPFS is the part name while PolarFire SoC is the marketing name. I will switch it in the next version to POLARFIRE_SOC_MBOX, which better matches the config option for the SoC directory that's in Atish's patches anyway. > > +++ b/drivers/mailbox/mailbox-mpfs.c > > @@ -0,0 +1,285 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Microchip MPFS system controller/mailbox controller driver > > The same might apply here. > > > Best regards, > Jonathan Neuschäfer >
