Re: [PATCH 1/6] mbox: add polarfire soc system controller mailbox

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 30/11/2020 21:50, Damien Le Moal wrote:
On 2020/11/30 22:23, Conor.Dooley@xxxxxxxxxxxxx wrote:
On 20/11/2020 00:05, Damien Le Moal wrote:
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

On 2020/11/20 2:05, conor.dooley@xxxxxxxxxxxxx wrote:
From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

This driver adds support for the single mailbox channel of the MSS
system controller on the Microchip PolarFire SoC.

Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
---
  drivers/mailbox/Kconfig        |  12 ++
  drivers/mailbox/Makefile       |   2 +
  drivers/mailbox/mailbox-mpfs.c | 296 +++++++++++++++++++++++++++++++++
  3 files changed, 310 insertions(+)
  create mode 100644 drivers/mailbox/mailbox-mpfs.c

diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
index 05b1009e2820..4881a519683a 100644
--- a/drivers/mailbox/Kconfig
+++ b/drivers/mailbox/Kconfig
@@ -153,6 +153,18 @@ config MAILBOX_TEST
         Test client to help with testing new Controller driver
         implementations.

+config MPFS_MBOX
+     tristate "MPFS Mailbox"
+     depends on HAS_IOMEM
Shouldn't this dependency be on SOC_MICROCHIP_POLARFIRE ?
Not entirely sure what you mean by this one. You want the HAS_IOMEM to be selected by SOC_MICROCHIP_POLARFIRE ?

Sorry, I was not clear. I was referring to MPFS_MBOX: shouldn't it be dependent
on SOC_MICROCHIP_POLARFIRE ? E.g.:

config MPFS_MBOX
	tristate "MPFS Mailbox"
	depends on HAS_IOMEM
	depends on SOC_MICROCHIP_POLARFIRE
	...

probably depends on SOC_MICROCHIP_POLARFIRE || COMPILE_TEST
so that you can build a "compile test" kernel with as much enabled as possible

--
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

https://www.codethink.co.uk/privacy.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux