Hi Sonal, On Sat, Nov 28, 2020 at 04:00:34PM -0800, Sonal Santan wrote: > From: Sonal Santan <sonal.santan@xxxxxxxxxx> > > Add XRT UAPI header files which describe flash layout, XRT > mailbox protocol, xclBin/axlf FPGA image container format and > XRT management physical function driver ioctl interfaces. > > flash_xrt_data.h: > Layout used by XRT to store private data on flash. > > mailbox_proto.h: > Mailbox opcodes and high level data structures representing > various kinds of information like sensors, clock, etc. > > mailbox_transport.h: > Transport protocol used by mailbox. > > xclbin.h: > Container format used to store compiled FPGA image which includes > bitstream and metadata. Can these headers be introduced together with the code that uses them as logical change? I haven't looked too closely, but it helps reviewing if you can break it into smaller pieces that can stand by themselves. Thanks, Moritz