On 1/12/20 12:03 pm, Andrew Lunn wrote: > On Tue, Dec 01, 2020 at 11:35:07AM +1300, Aryan Srivastava wrote: >> Add device tree file for x530 board. This has an Armada 385 SoC. Has >> NAND-flash for user storage and SPI for booting. Covers majority of x530 >> and GS980MX variants. > Hi Aryan > > What exactly does that mean, it covers most variants? We were trying to avoid the patch submission becoming marketing spam and have probably been a little too vague. Between the x530, x530L and GS980MX there are 24 different models. The differences between them are in the type and number of switch ASICs, the number of PSUs and whether PoE is supported. But the CPU block is largely the same between models. > I'm just wondering if this should be a .dtsi file, and then each > variant has a .dts file specific to it? This is what we've done in our kernel fork. But for upstreaming we wanted to start slow and maybe move things into one or more common .dtsi files if/when needed (in particular there are some models in development now that use different i2c mux and hwmon chips). > Or is the hardware itself the > same, and only the software varies between the variants? Kind of both. This patch submission basically represents the common items among all the (currently shipping) variants.
