Re: [PATCH 1/2 v6] dt-bindings: leds: Add DT binding for Richtek RT8515

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 24, 2020 at 12:45:43AM +0200, Sakari Ailus wrote:
> Hi Linus,
> 
> On Mon, Nov 23, 2020 at 10:44:38PM +0100, Linus Walleij wrote:
> > diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> > index f1211e7045f1..92fa90b4a671 100644
> > --- a/Documentation/devicetree/bindings/leds/common.yaml
> > +++ b/Documentation/devicetree/bindings/leds/common.yaml
> > @@ -151,6 +151,12 @@ properties:
> >        Maximum flash LED supply current in microamperes. Required for flash LED
> >        nodes with configurable current.
> >  
> > +  torch-max-microamp:
> > +    description:
> > +      Maximum flash LED supply current in microamperes, when the flash LED is
> > +      used as a torch (flashlight). This is usually lower than the flash mode
> > +      maximum current, if the LED supports torch mode.
> 
> Thanks for the update.
> 
> One more thing. The other flash LED DT bindings are using led-max-microamp
> for the torch mode --- for it's what the non-flash LEDs do.
> 
> Could you use the same here?

Good point. Seems like it as led-max-microamp should be the max steady 
state current whereas flash-max-microamp is the max for a limited time.

Rob



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux