On Mon, Nov 30, 2020 at 2:10 PM Daniel Palmer <daniel@xxxxxxxx> wrote: > > +&riu { > + smpctrl@204000 { > + compatible = "mstar,smpctrl"; > + reg = <0x204000 0x200>; > + status = "okay"; > + }; You probably want some more specific compatible value, in case there are multiple SoCs from mstar that have an smpctrl block and they don't all use an exactly identical register layout. Arnd