Hi Pali, > LED2 is connected to MPP1_2 pin. It is working only on V7 boards. > V5 boards have hw bug which cause that LED2 is non-working. > > So enable LED2 only for Espressobin V7 boards. > > Note that LED1 is connected to LED_WLAN# pin on miniPCIe card and LED3 to > power supply. Therefore on Espressobin board only LED2 can be controlled > directly from the host. LED1 is possible to control via WiFi card inserted > in miniPCIe slot if driver for particular card supports it. > > Signed-off-by: Pali Rohár <pali@xxxxxxxxxx> > Tested-by: Gérald Kerma <gerald@xxxxxxx> Applied on mvebu/dt64 Thanks, Gregory > > --- > > Previous version of this patch was sent by Uwe in March 2018, but it did > not work on any tested V5 board. Now we know it was due to V5 HW bug. > > https://lore.kernel.org/linux-arm-kernel/20180321105005.18426-3-u.kleine-koenig@xxxxxxxxxxxxxx/ > --- > .../dts/marvell/armada-3720-espressobin-v7-emmc.dts | 4 ++++ > .../boot/dts/marvell/armada-3720-espressobin-v7.dts | 4 ++++ > .../boot/dts/marvell/armada-3720-espressobin.dtsi | 13 +++++++++++++ > 3 files changed, 21 insertions(+) > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts > index 4775a7eda481..75401eab4d42 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts > @@ -39,3 +39,7 @@ > &sdhci0 { > status = "okay"; > }; > + > +&led2 { > + status = "okay"; > +}; > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts > index c47a93978386..48a7f50fb427 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts > @@ -34,3 +34,7 @@ > &switch0port3 { > label = "wan"; > }; > + > +&led2 { > + status = "okay"; > +}; > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi > index 8a1c678bea5f..daffe136c523 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi > @@ -41,6 +41,19 @@ > 3300000 0x0>; > enable-active-high; > }; > + > + led2: gpio-led2 { > + /* led2 is working only on v7 board */ > + status = "disabled"; > + > + compatible = "gpio-leds"; > + > + led2 { > + label = "led2"; > + gpios = <&gpionb 2 GPIO_ACTIVE_LOW>; > + default-state = "off"; > + }; > + }; > }; > > /* J9 */ > -- > 2.20.1 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com
