Re: [PATCH] arm64: dts: mt8183: Add pwm and backlight node

[Matthias Brugger <matthias.bgg@xxxxxxxxx>]

On 25/11/2020 11:24, Enric Balletbo i Serra wrote:
> Hi Hsin-Yi,
>
> Thank you for your patch.
>
> On 24/11/20 5:12, Hsin-Yi Wang wrote:
> > Add pwm to mt8183 and backlight to mt8183-kukui.
> >
> > Signed-off-by: Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx>
> > ---
>
> Picked the patch and checked that pwm for the backlight is working as expected
> on my Lenovo Ideapad Duet.
>
> Tested-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>

Applied to v5.10-next/dts64

Thanks!

> >   .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 28 +++++++++++++++++++
> >   arch/arm64/boot/dts/mediatek/mt8183.dtsi      | 10 +++++++
> >   2 files changed, 38 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> > index 85f7c33ba4461..bf2ad1294dd30 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> > @@ -19,6 +19,17 @@ chosen {
> >   		stdout-path = "serial0:115200n8";
> >   	};
> >   
> > +	backlight_lcd0: backlight_lcd0 {
> > +		compatible = "pwm-backlight";
> > +		pwms = <&pwm0 0 500000>;
> > +		power-supply = <&bl_pp5000>;
> > +		enable-gpios = <&pio 176 0>;
> > +		brightness-levels = <0 1023>;
> > +		num-interpolated-steps = <1023>;
> > +		default-brightness-level = <576>;
> > +		status = "okay";
> > +	};
> > +
> >   	memory@40000000 {
> >   		device_type = "memory";
> >   		reg = <0 0x40000000 0 0x80000000>;
> > @@ -536,6 +547,17 @@ pins_clk {
> >   		};
> >   	};
> >   
> > +	pwm0_pin_default: pwm0_pin_default {
> > +		pins1 {
> > +			pinmux = <PINMUX_GPIO176__FUNC_GPIO176>;
> > +			output-high;
> > +			bias-pull-up;
> > +		};
> > +		pins2 {
> > +			pinmux = <PINMUX_GPIO43__FUNC_DISP_PWM>;
> > +		};
> > +	};
> > +
> >   	scp_pins: scp {
> >   		pins_scp_uart {
> >   			pinmux = <PINMUX_GPIO110__FUNC_TP_URXD1_AO>,
> > @@ -670,6 +692,12 @@ pins_wifi_wakeup {
> >   	};
> >   };
> >   
> > +&pwm0 {
> > +	status = "okay";
> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&pwm0_pin_default>;
> > +};
> > +
> >   &scp {
> >   	status = "okay";
> >   	pinctrl-names = "default";
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > index 08a914d3a6435..a974bad899365 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > @@ -479,6 +479,16 @@ spi0: spi@1100a000 {
> >   			status = "disabled";
> >   		};
> >   
> > +		pwm0: pwm@1100e000 {
> > +			compatible = "mediatek,mt8183-disp-pwm";
> > +			reg = <0 0x1100e000 0 0x1000>;
> > +			interrupts = <GIC_SPI 128 IRQ_TYPE_LEVEL_LOW>;
> > +			#pwm-cells = <2>;
> > +			clocks = <&topckgen CLK_TOP_MUX_DISP_PWM>,
> > +					<&infracfg CLK_INFRA_DISP_PWM>;
> > +			clock-names = "main", "mm";
> > +		};
> > +
> >   		i2c3: i2c@1100f000 {
> >   			compatible = "mediatek,mt8183-i2c";
> >   			reg = <0 0x1100f000 0 0x1000>,