Hi Prabhakar, On Thu, Nov 26, 2020 at 11:31 AM Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote: > The 8-bit ov7725 sensors can also be connected to the camera daughter > board. > > This patch creates a separate dtsi file for ov7725 sensors and is included > in r8a7742-iwg21d-q7-dbcm-ca.dts. The user can set VINx_SENSOR depending > on the cameras connected. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > Reviewed-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> Thanks for your patch! Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> However, I think this can still be improved upon. As it's a bit difficult to explain, I'll send an updated version of your series with my suggestions applied. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds