On Wed, 25 Nov 2020 13:37:39 -0600 George McCollister wrote: > Add a driver with initial support for the Arrow SpeedChips XRS7000 > series of gigabit Ethernet switch chips which are typically used in > critical networking applications. > > The switches have up to three RGMII ports and one RMII port. > Management to the switches can be performed over i2c or mdio. > > Support for advanced features such as PTP and > HSR/PRP (IEC 62439-3 Clause 5 & 4) is not included in this patch and > may be added at a later date. > > Signed-off-by: George McCollister <george.mccollister@xxxxxxxxx> You need to add symbol exports otherwise this won't build with allmodconfig: ERROR: modpost: "xrs7004f_info" [drivers/net/dsa/xrs700x/xrs700x_mdio.ko] undefined! ERROR: modpost: "xrs7004e_info" [drivers/net/dsa/xrs700x/xrs700x_mdio.ko] undefined! ERROR: modpost: "xrs7003f_info" [drivers/net/dsa/xrs700x/xrs700x_mdio.ko] undefined! ERROR: modpost: "xrs7003e_info" [drivers/net/dsa/xrs700x/xrs700x_mdio.ko] undefined! ERROR: modpost: "xrs7004f_info" [drivers/net/dsa/xrs700x/xrs700x_i2c.ko] undefined! ERROR: modpost: "xrs7004e_info" [drivers/net/dsa/xrs700x/xrs700x_i2c.ko] undefined! ERROR: modpost: "xrs7003f_info" [drivers/net/dsa/xrs700x/xrs700x_i2c.ko] undefined! ERROR: modpost: "xrs7003e_info" [drivers/net/dsa/xrs700x/xrs700x_i2c.ko] undefined! > + {XRS_RX_UNDERSIZE_L, "rx_undersize"}, > + {XRS_RX_FRAGMENTS_L, "rx_fragments"}, > + {XRS_RX_OVERSIZE_L, "rx_oversize"}, > + {XRS_RX_JABBER_L, "rx_jabber"}, > + {XRS_RX_ERR_L, "rx_err"}, > + {XRS_RX_CRC_L, "rx_crc"}, As Vladimir already mentioned to you the statistics which have corresponding entries in struct rtnl_link_stats64 should be reported the standard way. The infra for DSA may not be in place yet, so best if you just drop those for now.