Boris, On Sun, Jun 22, 2014 at 10:56:54PM +0200, Boris BREZILLON wrote: > > On 20/06/2014 17:01, Boris BREZILLON wrote: > > Add new atmel AIC (Advanced Interrupt Controller) driver based on the > > generic chip infrastructure. > > > > This driver is only compatible with dt enabled board and replaces the old > > implementation found in arch/arm/mach-at91/irq.c. > > > > Signed-off-by: Boris BREZILLON <boris.brezillon@xxxxxxxxxxxxxxxxxx> > > --- > > drivers/irqchip/Kconfig | 7 + > > drivers/irqchip/Makefile | 1 + > > drivers/irqchip/irq-atmel-aic.c | 700 ++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 708 insertions(+) > > create mode 100644 drivers/irqchip/irq-atmel-aic.c > > > > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig > > index bbb746e..6a7ad81 100644 > > --- a/drivers/irqchip/Kconfig > > +++ b/drivers/irqchip/Kconfig > > @@ -30,6 +30,13 @@ config ARM_VIC_NR > > The maximum number of VICs available in the system, for > > power management. > > > > [...] > > > + > > +static int at91_aic_common_irq_domain_xlate(struct irq_domain *d, > > This function should be named aic_common_irq_domain_xslate to be > consistent with other function names. > I'll fix that for the next version. Other than this one change, this series looks good wrt to irqchip. When you respin, please adjust the patch subject lines like so: irqchip: atmel-aic: Add new atmel AIC driver Note the capitalization. Also, if you could add Thomas' Ack to the first patch, that would be appreciated. Once you post the new series, I assume it's ok to apply patches 1-3 to irqchip/core, or are there some dependency considerations? thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
