On Mon, Nov 23, 2020 at 5:02 PM krzk@xxxxxxxxxx <krzk@xxxxxxxxxx> wrote:
>
> On Mon, Nov 23, 2020 at 04:55:26PM +0900, Bongsu Jeon wrote:
> > Since S3FWRN82 NFC Chip, The UART interface can be used.
> > S3FWRN82 supports I2C and UART interface.
> >
> > Signed-off-by: Bongsu Jeon <bongsu.jeon@xxxxxxxxxxx>
> > ---
> > .../bindings/net/nfc/samsung,s3fwrn5.yaml | 28 +++++++++++++++++--
> > 1 file changed, 26 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml b/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml
> > index cb0b8a560282..37b3e5ae5681 100644
> > --- a/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml
> > +++ b/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml
> > @@ -13,6 +13,7 @@ maintainers:
> > properties:
> > compatible:
> > const: samsung,s3fwrn5-i2c
> > + const: samsung,s3fwrn82-uart
>
> This does not work, you need to use enum. Did you run at least
> dt_bindings_check?
>
Sorry. I didn't. I fixed it as below and ran dt_bindings_check.
compatible:
oneOf:
- enum:
- samsung,s3fwrn5-i2c
- samsung,s3fwrn82
> The compatible should be just "samsung,s3fwrn82". I think it was a
> mistake in the first s3fwrn5 submission to add a interface to
> compatible.
>
Ok. I will change the name.
> >
> > en-gpios:
> > maxItems: 1
> > @@ -47,10 +48,19 @@ additionalProperties: false
> > required:
> > - compatible
> > - en-gpios
> > - - interrupts
> > - - reg
> > - wake-gpios
> >
> > +allOf:
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: samsung,s3fwrn5-i2c
> > + then:
> > + required:
> > + - interrupts
> > + - reg
> > +
> > examples:
> > - |
> > #include <dt-bindings/gpio/gpio.h>
> > @@ -71,3 +81,17 @@ examples:
> > wake-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>;
> > };
> > };
> > + # UART example on Raspberry Pi
> > + - |
> > + &uart0 {
> > + status = "okay";
> > +
> > + s3fwrn82_uart {
>
> Just "bluetooth" to follow Devicetree specification.
Sorry. I don't understand this comment.
Could you explain it?
Does it mean i need to refer to the net/broadcom-bluetooth.txt?
>
> Best regards,
> Krzysztof
