On 11/20/2020 10:16 AM, George McCollister wrote: > Add support for Arrow SpeedChips XRS700x single byte tag trailer. This > is modeled on tag_trailer.c which works in a similar way. > > Signed-off-by: George McCollister <george.mccollister@xxxxxxxxx> One question below: [snip] > + if (pskb_trim_rcsum(skb, skb->len - 1)) > + return NULL; > + > + /* Frame is forwarded by hardware, don't forward in software. */ > + skb->offload_fwd_mark = 1; Given the switch does not give you a forwarding reason, I suppose this is fine, but do you possibly have to qualify this against different source MAC addresses? -- Florian
