On 23/11/2020 22:31:05+0100, Jonathan Neuschäfer wrote: > > > + res = regmap_write(rtc->ec->regmap, NTXEC_REG_WRITE_MINUTE, ntxec_reg8(tm->tm_min)); > > > + if (res) > > > + return res; > > > + > > > + return regmap_write(rtc->ec->regmap, NTXEC_REG_WRITE_SECOND, ntxec_reg8(tm->tm_sec)); > > > > Couldn't you do a regmap_block_write or a regmap_multi_reg_write which > > would be more efficient as they would be locking the regmap only once. > > I can't find regmap_block_write anywhere, but regmap_multi_reg_write > looks like a good approach to simplify the code here. > I was thinking regmap_bulk_write but regmap_multi_reg_write is probably more fitting here. > > [...] > > Note that this won't compile after > > https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/commit/?id=fdcfd854333be5b30377dc5daa9cd0fa1643a979 > > > > We can solve that with immutable branches though. > > Thanks for the heads-up. Please let me know if/when there is any action > that I need to take here. > I wouldn't think so, I can carry a patch once Lee provides his usual immutable branch. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
