RE: [PATCH v2 0/2] Add drivers for Intel Keem Bay SoC watchdog

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

> From: Ayyathurai, Vijayakannan <vijayakannan.ayyathurai@xxxxxxxxx>
> Sent: Wednesday, 11 November, 2020 1:53 AM
> Subject: [PATCH v2 0/2] Add drivers for Intel Keem Bay SoC watchdog
> 
> From: Vijayakannan Ayyathurai <vijayakannan.ayyathurai@xxxxxxxxx>
> 
> Hi,
> 
> This patch set adds the watchdog timer driver support for Intel Keem Bay Soc.
> 
> Patch 1 holds the driver and Patch 2 holds the Device Tree
> binding documentation.
> 
> This driver was tested on the Keem Bay evaluation module board.
> 
> Thank you,
> Vijay
> 
> Changes since v1:
>  - Fix indentation error in the dt-bindings file.
>  - Use true/false in the second arg of keembay_wdt_set_timeout_reg().
>  - Fix the watchdog start sequence.
>  - Avoid reduntant timeout register setting.
>  - Remove min usage to find actual time at keembay_wdt_set_timeout().
>  - Remove timeout configuration boundary check at
>    keembay_wdt_set_pretimeout().
>  - Use devm_watchdog_register_device() for wdt registration, which
>    eventually supports driver unload functionality as well.
> 

Please consider review this patch and let me know 
if there is further feedback.

> Vijayakannan Ayyathurai (2):
>   watchdog: Add watchdog driver for Intel Keembay Soc
>   dt-bindings: watchdog: Add bindings for Intel Keem Bay SoC
> 
>  .../bindings/watchdog/intel,keembay-wdt.yaml  |  57 ++++
>  drivers/watchdog/Kconfig                      |  13 +
>  drivers/watchdog/Makefile                     |   1 +
>  drivers/watchdog/keembay_wdt.c                | 288 ++++++++++++++++++
>  4 files changed, 359 insertions(+)
>  create mode 100644
> Documentation/devicetree/bindings/watchdog/intel,keembay-wdt.yaml
>  create mode 100644 drivers/watchdog/keembay_wdt.c
> 
> 
> base-commit: 3650b228f83adda7e5ee532e2b90429c03f7b9ec
> --
> 2.17.1

Thanks,
Vijay




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux