> @@ -459,7 +459,7 @@ static int mv88e6xxx_port_set_cmode(struct mv88e6xxx_chip *chip, int port, > chip->ports[port].cmode = cmode; > > lane = mv88e6xxx_serdes_get_lane(chip, port); > - if (!lane) > + if (lane < 0) > return -ENODEV; return lane since lane is an errno. Other than that: Reviewed-by: Andrew Lunn <andrew@xxxxxxx> Andrew