On 16-11-20, 08:46, Rafał Miłecki wrote: > From: Rafał Miłecki <rafal@xxxxxxxxxx> > > 1. Change syntax from txt to yaml > 2. Drop "Driver for" from the title > 3. Drop "reg = <0x0>;" from example (noticed by dt_binding_check) > 4. Specify license You missed Ccing Rob > > Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx> > --- > I think this should go through linux-phy tree. Kishon, Vinod, can you > take this patch? > > This patch generates a false positive checkpatch.pl warning [0]. > Please ignore: > WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst That is okay, it is a warning ;-) > > [0] https://lkml.org/lkml/2020/2/18/1084 > --- > .../bindings/phy/bcm-ns-usb3-phy.txt | 34 ---------- > .../bindings/phy/bcm-ns-usb3-phy.yaml | 62 +++++++++++++++++++ > 2 files changed, 62 insertions(+), 34 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/phy/bcm-ns-usb3-phy.txt > create mode 100644 Documentation/devicetree/bindings/phy/bcm-ns-usb3-phy.yaml > > diff --git a/Documentation/devicetree/bindings/phy/bcm-ns-usb3-phy.txt b/Documentation/devicetree/bindings/phy/bcm-ns-usb3-phy.txt > deleted file mode 100644 > index 32f057260351..000000000000 > --- a/Documentation/devicetree/bindings/phy/bcm-ns-usb3-phy.txt > +++ /dev/null > @@ -1,34 +0,0 @@ > -Driver for Broadcom Northstar USB 3.0 PHY > - > -Required properties: > - > -- compatible: one of: "brcm,ns-ax-usb3-phy", "brcm,ns-bx-usb3-phy". > -- reg: address of MDIO bus device > -- usb3-dmp-syscon: phandle to syscon with DMP (Device Management Plugin) > - registers > -- #phy-cells: must be 0 > - > -Initialization of USB 3.0 PHY depends on Northstar version. There are currently > -three known series: Ax, Bx and Cx. > -Known A0: BCM4707 rev 0 > -Known B0: BCM4707 rev 4, BCM53573 rev 2 > -Known B1: BCM4707 rev 6 > -Known C0: BCM47094 rev 0 > - > -Example: > - mdio: mdio@0 { > - reg = <0x0>; > - #size-cells = <1>; > - #address-cells = <0>; > - > - usb3-phy@10 { > - compatible = "brcm,ns-ax-usb3-phy"; > - reg = <0x10>; > - usb3-dmp-syscon = <&usb3_dmp>; > - #phy-cells = <0>; > - }; > - }; > - > - usb3_dmp: syscon@18105000 { > - reg = <0x18105000 0x1000>; > - }; > diff --git a/Documentation/devicetree/bindings/phy/bcm-ns-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/bcm-ns-usb3-phy.yaml > new file mode 100644 > index 000000000000..7fd419db45d0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/bcm-ns-usb3-phy.yaml > @@ -0,0 +1,62 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/bcm-ns-usb3-phy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Broadcom Northstar USB 3.0 PHY > + > +description: | > + Initialization of USB 3.0 PHY depends on Northstar version. There are currently > + three known series: Ax, Bx and Cx. > + Known A0: BCM4707 rev 0 > + Known B0: BCM4707 rev 4, BCM53573 rev 2 > + Known B1: BCM4707 rev 6 > + Known C0: BCM47094 rev 0 > + > +maintainers: > + - Rafał Miłecki <rafal@xxxxxxxxxx> > + > +properties: > + compatible: > + enum: > + - brcm,ns-ax-usb3-phy > + - brcm,ns-bx-usb3-phy > + > + reg: > + description: address of MDIO bus device > + maxItems: 1 > + > + usb3-dmp-syscon: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle to the DMP (Device Management Plugin) syscon > + > + "#phy-cells": > + const: 0 > + > +required: > + - compatible > + - reg > + - usb3-dmp-syscon > + - "#phy-cells" > + > +additionalProperties: false > + > +examples: > + - | > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + usb3-phy@10 { > + compatible = "brcm,ns-ax-usb3-phy"; > + reg = <0x10>; > + usb3-dmp-syscon = <&usb3_dmp>; > + #phy-cells = <0>; > + }; > + }; > + > + usb3_dmp: syscon@18105000 { > + reg = <0x18105000 0x1000>; > + }; > -- > 2.27.0 -- ~Vinod
