Hi Rob On Mon, 16 Nov 2020 at 16:28, Rob Herring <robh@xxxxxxxxxx> wrote: > > On Sat, 14 Nov 2020 09:46:08 +0100, Grzegorz Jaszczyk wrote: > > From: Suman Anna <s-anna@xxxxxx> > > > > The Programmable Real-Time Unit and Industrial Communication Subsystem > > (PRU-ICSS or simply PRUSS) on various TI SoCs consists of dual 32-bit > > RISC cores (Programmable Real-Time Units, or PRUs) for program execution. > > > > The K3 AM65x amd J721E SoCs have the next generation of the PRU-ICSS IP, > > commonly called ICSSG. The ICSSG IP on AM65x SoCs has two PRU cores, > > two auxiliary custom PRU cores called Real Time Units (RTUs). The K3 > > AM65x SR2.0 and J721E SoCs have a revised version of the ICSSG IP, and > > include two additional custom auxiliary PRU cores called Transmit PRUs > > (Tx_PRUs). > > > > This patch adds the bindings for these PRU cores. The binding covers the > > OMAP architecture SoCs - AM33xx, AM437x and AM57xx; Keystone 2 architecture > > based 66AK2G SoC; and the K3 architecture based SoCs - AM65x and J721E. The > > Davinci based OMAPL138 SoCs will be covered in a future patch. > > > > Co-developed-by: Roger Quadros <rogerq@xxxxxx> > > Signed-off-by: Roger Quadros <rogerq@xxxxxx> > > Signed-off-by: Suman Anna <s-anna@xxxxxx> > > Signed-off-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@xxxxxxxxxx> > > --- > > .../bindings/remoteproc/ti,pru-rproc.yaml | 214 ++++++++++++++++++ > > 1 file changed, 214 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml:37:6: [warning] wrong indentation: expected 6 but found 5 (indentation) > ./Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml:92:2: [warning] wrong indentation: expected 2 but found 1 (indentation) > > dtschema/dtc warnings/errors: > > > See https://patchwork.ozlabs.org/patch/1400241 > > The base for the patch is generally the last rc1. Any dependencies > should be noted. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. Sorry for that - I've run dt_binding_check which completes without any warnings/errors but I didn't had yamllint installed. I will fix mentioned warnings for v2. Best regards, Grzegorz
