On 10-11-20, 08:54, Paul Cercueil wrote: > Hi Zhou, > > Le sam. 7 nov. 2020 à 20:20, 周琰杰 (Zhou Yanjie) > <zhouyanjie@xxxxxxxxxxxxxx> a écrit : > > Add the dmaengine bindings for the JZ4775 SoC and the X2000 SoC from > > Ingenic. > > > > 周琰杰 (Zhou Yanjie) (2): > > dt-bindings: dmaengine: Add JZ4775 bindings. > > dt-bindings: dmaengine: Add X2000 bindings. > > > > include/dt-bindings/dma/jz4775-dma.h | 44 +++++++++++++++++++++++++++++ > > include/dt-bindings/dma/x2000-dma.h | 54 > > ++++++++++++++++++++++++++++++++++++ > > If that's up to me, these macros aren't really needed, and you can put the > values directly in the dma cells. This is done already in jz4740.dtsi, > jz4725b.dtsi and jz4770.dtsi. But that is not really nice, it is good to define these rather than put numbers, the include/dt-bindings exists for this sole reason! -- ~Vinod
