Re: [PATCH] media: dt-bindings: coda: Add missing 'additionalProperties'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2020-11-17 at 07:48 -0600, Rob Herring wrote:
> On Thu, Nov 12, 2020 at 4:49 PM Rob Herring <robh@xxxxxxxxxx> wrote:
> > 'additionalProperties' is now required by the meta-schema. Add it for
> > coda.
> > 
> > Cc: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> > Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> > Cc: linux-media@xxxxxxxxxxxxxxx
> > Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/media/coda.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> 
> I missed an error this introduces:
> 
> /home/rob/proj/git/linux-dt/.build-arm/Documentation/devicetree/bindings/media/coda.example.dt.yaml:
> video-codec@63ff4000: 'interrupts' does not match any of the regexes:
> 'pinctrl-[0-9]+'
>         From schema:
> /home/rob/proj/git/linux-dt/Documentation/devicetree/bindings/media/coda.yaml

Right, because interrupts are only specified conditionally:

allOf:
  - if:
      properties:
        compatible:
          contains:
            const: cnm,coda960
    then:
      properties:
        interrupts:
          items:
            - description: BIT processor interrupt
            - description: JPEG unit interrupt

        interrupt-names:
          items:
            - const: bit
            - const: jpeg
    else:
      properties:
        interrupts:
          items:
            - description: BIT processor interrupt

What is the proper way to fix this?

regards
Philipp



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux