> -----Original Message----- > From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > Sent: 2020年11月15日 0:01 > To: Alice Guo <alice.guo@xxxxxxx> > Cc: robh+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; > dl-linux-imx <linux-imx@xxxxxxx>; Peng Fan <peng.fan@xxxxxxx>; > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: [EXT] Re: [PATCH v3 3/4] arm64: dts: imx8m: add nvmem-cell related > stuff > > Caution: EXT Email > > On Fri, Nov 13, 2020 at 07:04:08PM +0800, Alice Guo wrote: > > Add nvmem-cell related stuff for the soc unique ID. > > Do not silently ignore comments during review. Let me repeat my comment > from v1: > > Subject and commit msg: please do not add "stuff" but describe what are you > adding and why (what is the purpose, feature, benefit). > "Stuff" is too generic. > > I can rephrase it, since maybe I was not understood. Do not use words like > "stuff" or "thing". Instead describe exactly what you are adding and answer to > the most important question: why are you adding it. > > Best regards, > Krzysztof > [Alice Guo] Hi, I will modify according to your comment. Best Regards, Alice > > > > Signed-off-by: Alice Guo <alice.guo@xxxxxxx> > > --- > > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 6 ++++++ > > arch/arm64/boot/dts/freescale/imx8mn.dtsi | 6 ++++++ > > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 6 ++++++ > > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 6 ++++++ > > 4 files changed, 24 insertions(+)
