Quoting Damien Le Moal (2020-11-13 00:23:52) > On 2020/11/13 17:11, Stephen Boyd wrote: > > > > Also of_clk_init() is for the CLK_OF_DECLARE() users and if they can > > wait to platform bus population time then they could be converted to > > regular old platform device drivers. Maybe the problem is the clk driver > > you're using is only using CLK_OF_DECLARE() and not registering a > > platform driver? > > Yep, correct, that is what I did. SO yes, indeed, if I where to use a regular > platform_driver, then the of_clk_init() change would not be needed. > > For the clock driver, I followed the pattern used by most other drivers with the > majority I think using CLK_OF_DECLARE(). I did see some using the platform > driver declaration though. > > I could spend time trying to figure out if I can get away without using > CLK_OF_DECLARE(), but since I think other riscv board clock driver are arriving, > we may as well keep that of_clk_init() change, no ? > Sure keeping of_clk_init() in riscv architecture code is fine. It would be good to use a platform driver though and avoid the use of CLK_OF_DECLARE() so we don't burden ourselves with more code that registers clks early unnecessarily.
