On Sun, Nov 15, 2020 at 11:32:51AM +0100, Krzysztof Kozlowski wrote: > On Fri, Nov 13, 2020 at 10:25:23PM +0100, Martin Jücker wrote: > > The p4note family contains a couple of variants of the Galaxy Note 10.1 > > tablet with mainly different modems. The GT-N8010/GT-N8013 is the wifi > > only version. > > > > Signed-off-by: Martin Jücker <martin.juecker@xxxxxxxxx> > > --- > > arch/arm/boot/dts/Makefile | 1 + > > arch/arm/boot/dts/exynos4412-p4note-n8010.dts | 17 + > > arch/arm/boot/dts/exynos4412-p4note.dtsi | 1132 +++++++++++++++++ > > 3 files changed, 1150 insertions(+) > > create mode 100644 arch/arm/boot/dts/exynos4412-p4note-n8010.dts > > create mode 100644 arch/arm/boot/dts/exynos4412-p4note.dtsi > > > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > > index ce66ffd5a1bb..55ffee2b20f8 100644 > > --- a/arch/arm/boot/dts/Makefile > > +++ b/arch/arm/boot/dts/Makefile > > @@ -197,6 +197,7 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \ > > exynos4412-odroidx.dtb \ > > exynos4412-odroidx2.dtb \ > > exynos4412-origen.dtb \ > > + exynos4412-p4note-n8010.dtb \ > > exynos4412-smdk4412.dtb \ > > exynos4412-tiny4412.dtb \ > > exynos4412-trats2.dtb > > diff --git a/arch/arm/boot/dts/exynos4412-p4note-n8010.dts b/arch/arm/boot/dts/exynos4412-p4note-n8010.dts > > new file mode 100644 > > index 000000000000..9f559425bd2c > > --- /dev/null > > +++ b/arch/arm/boot/dts/exynos4412-p4note-n8010.dts > > @@ -0,0 +1,17 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Samsung's Galaxy Note 10.1 - N801x (wifi only version) > > + * > > + * Copyright (c) 2013 Samsung Electronics Co., Ltd. > > + * http://www.samsung.com > > Here and in other files - why did you remove your copyright? My comment > from previous version: "If it is true, then include the copyright of > original work as well." > > Best regards, > Krzysztof > Hey Krzysztof, in the second response you wrote that "usually we keep the copyright of original file", I understood this as only the Samsung header as it is done for the midas, i930x and n710x. A lot of it is basically the same but with changed gpios. I really don't need my copyright up there if it's not strictly necessary. Cheers Martin
