Re: [PATCH mvebu-dt 3/6] ARM: dts: turris-omnia: describe ethernet-phy interrupt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 14 Nov 2020 17:34:39 +0100
Andrew Lunn <andrew@xxxxxxx> wrote:

> On Sat, Nov 14, 2020 at 05:04:06PM +0100, Marek Behún wrote:
> > Describe ethernet-phy interrupt for Turris Omnia so that the PHY does
> > not need to be polled. We also need to describe the PCA9538 as an
> > interrupt controller.
> > 
> > Signed-off-by: Marek Behún <kabel@xxxxxxxxxx>
> > Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")  
> 
> I'm not sure the fixes is justified. This is an optimisation, not a
> fix.

I considered this as a fix in the sense that it should have been there
from the beginning... Although the driver works, the devicetree does not
describe the device correctly without it.

> 
> Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
> 
>     Andrew





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux