Hi, Here's a conversion of vc4 to remove the hand-rolled atomic_commit helper from vc4 in favour of the generic one. This requires some rework of vc4, but also a new hook and some documentation for corner-cases in the DRM core that have been reported and explained by Daniel recently. Let me know what you think, Maxime Maxime Ripard (8): drm: Introduce an atomic_commit_setup function drm: Document use-after-free gotcha with private objects drm/vc4: kms: Move HVS state helpers around drm/vc4: kms: Simplify a bit the private obj state hooks drm/vc4: Simplify a bit the global atomic_check drm/vc4: kms: Wait on previous FIFO users before a commit drm/vc4: kms: Remove async modeset semaphore drm/vc4: kms: Convert to atomic helpers drivers/gpu/drm/drm_atomic_helper.c | 6 + drivers/gpu/drm/vc4/vc4_crtc.c | 13 -- drivers/gpu/drm/vc4/vc4_drv.h | 2 - drivers/gpu/drm/vc4/vc4_kms.c | 269 +++++++++++------------ include/drm/drm_atomic.h | 18 ++ include/drm/drm_modeset_helper_vtables.h | 18 ++ 6 files changed, 173 insertions(+), 153 deletions(-) -- 2.28.0
