On Wed, Nov 11, 2020 at 2:18 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > On Wed, 11 Nov 2020 09:25:23 -0600, Adam Ford wrote: > > Add binding doc for fsl,spba-bus. > > > > Signed-off-by: Adam Ford <aford173@xxxxxxxxx> > > --- > > make dt_binding_check showed no errors if I did this right. > > > > V4: Remove an accidental makefile change > > Move type:object under additional properties > > > > V3: Rebase sample from aips-bus example > > Split off from series adding i.MX8M Nano functions to reduce noise > > > > V2: Attempted to update yaml from feedback > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/bus/fsl,spba-bus.example.dt.yaml: bus@30000000: reg: [[805306368, 1048576]] is not of type 'object' > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/bus/fsl,spba-bus.yaml > Rob, Can you give me a pointer on what this message is saying? I don't undertsand the YAML language, and I cannot get my machine to generate the same messages you're seeing. > > See https://patchwork.ozlabs.org/patch/1398351 > > The base for the patch is generally the last rc1. Any dependencies > should be noted. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade I have installed yamllint, and I have run the above line, but when I run make dt_binding_check it fails to finish script even before I add this new binding. If I revert the Makefile back to before the implementation of yamllint, it works, but doesn't show the error. When I restore the Makefile, it runs but it doesn't show the error. Once I do a make clean, and run the dt_binding_check again, it fails to finish with the following error make[1]: *** [Documentation/devicetree/bindings/Makefile:59: Documentation/devicetree/bindings/processed-schema-examples.json] Error 123 It appears as if the processed-schema-examples.json is not generated at all. When I revert back to the older makefile, it appears that file is generated, but when I restore the makefile to the current version and run it again, it doesn't show the dtschema warnings/errors you see. I am guessing it's because the processed-schema-examples.json isn't being generated correctly after I run make clean. Do you have any ideas what might be missing from my build machine? adam > > Please check and re-submit. >
