On Mon, Nov 09, 2020 at 08:28:38PM +0000, Dongjiu Geng wrote: > Add clock drivers for hi3559A SoC, this driver controls the SoC > registers to supply different clocks to different IPs in the SoC. > > Signed-off-by: Dongjiu Geng <gengdongjiu@xxxxxxxxxx> > --- > drivers/clk/hisilicon/Kconfig | 7 + > drivers/clk/hisilicon/Makefile | 1 + > drivers/clk/hisilicon/clk-hi3559a.c | 873 ++++++++++++++++++ > include/dt-bindings/clock/hi3559av100-clock.h | 173 ++++ Is there a binding for this? The header should be part of it. > 4 files changed, 1054 insertions(+) > create mode 100644 drivers/clk/hisilicon/clk-hi3559a.c > create mode 100644 include/dt-bindings/clock/hi3559av100-clock.h > > diff --git a/drivers/clk/hisilicon/Kconfig b/drivers/clk/hisilicon/Kconfig > index 6a9e93a0bb95..5ecc37aaa118 100644 > --- a/drivers/clk/hisilicon/Kconfig > +++ b/drivers/clk/hisilicon/Kconfig > @@ -15,6 +15,13 @@ config COMMON_CLK_HI3519 > help > Build the clock driver for hi3519. > > +config COMMON_CLK_HI3559A > + bool "Hi3559A Clock Driver" > + depends on ARCH_HISI || COMPILE_TEST > + default ARCH_HISI > + help > + Build the clock driver for hi3559a. > + > config COMMON_CLK_HI3660 > bool "Hi3660 Clock Driver" > depends on ARCH_HISI || COMPILE_TEST > diff --git a/drivers/clk/hisilicon/Makefile b/drivers/clk/hisilicon/Makefile > index b2441b99f3d5..bc101833b35e 100644 > --- a/drivers/clk/hisilicon/Makefile > +++ b/drivers/clk/hisilicon/Makefile > @@ -17,3 +17,4 @@ obj-$(CONFIG_COMMON_CLK_HI6220) += clk-hi6220.o > obj-$(CONFIG_RESET_HISI) += reset.o > obj-$(CONFIG_STUB_CLK_HI6220) += clk-hi6220-stub.o > obj-$(CONFIG_STUB_CLK_HI3660) += clk-hi3660-stub.o > +obj-$(CONFIG_COMMON_CLK_HI3559A) += clk-hi3559a.o > diff --git a/drivers/clk/hisilicon/clk-hi3559a.c b/drivers/clk/hisilicon/clk-hi3559a.c > new file mode 100644 > index 000000000000..bd3921fc8c8e > --- /dev/null > +++ b/drivers/clk/hisilicon/clk-hi3559a.c > @@ -0,0 +1,873 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +/* > + * Hisilicon Hi3559A clock driver > + * > + * Copyright (c) 2019-2020 HiSilicon Technologies Co., Ltd. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. Don't need both this and SPDX tag. Kernel code should be GPL-2.0 (-only) generally. > + * > + * Author: Dongjiu Geng <gengdongjiu@xxxxxxxxxx> git will tell us this. Same comments apply to the header. Though DT headers should be dual licensed. Rob
