On 7/18/2020 1:50 PM, Lubomir Rintel wrote:
> On the XO-1.75, this node represents a bus interface that operates in slave
> mode and thus is only able to accommodate a single subnode; no address
> cells are necessary.
>
> The Documentation/devicetree/bindings/spi/spi-controller.yaml binding
> prefers that we drop the property instead of setting it to zero.
>
> This fixes a DT validation error:
>
> arch/arm/boot/dts/mmp2-olpc-xo-1-75.dt.yaml: spi@d4037000:
> { ... } is valid under each of {'required': ['spi-slave']},
> {'required': ['#address-cells']}
>
> We also need to drop #size-cells:
>
> arch/arm/boot/dts/mmp2-olpc-xo-1-75.dt.yaml: spi@d4037000:
> '#address-cells' is a dependency of '#size-cells'
>
> Signed-off-by: Lubomir Rintel <lkundrak@xxxxx>
This patch causes the following warning to be issued when validating the
mmp2 DTS files against specific bindings:
arch/arm/boot/dts/mmp2.dtsi:472.23-480.6: Warning (spi_bus_bridge):
/soc/apb@d4000000/spi@d4037000: incorrect #address-cells for SPI bus
also defined at arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts:225.7-237.3
arch/arm/boot/dts/mmp2.dtsi:472.23-480.6: Warning (spi_bus_bridge):
/soc/apb@d4000000/spi@d4037000: incorrect #size-cells for SPI bus
also defined at arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts:225.7-237.3
arch/arm/boot/dts/mmp2-olpc-xo-1-75.dt.yaml: Warning (spi_bus_reg):
Failed prerequisite 'spi_bus_bridge'
Is there a fix that we can apply to silence this warning? Thanks!
--
Florian
