On Mon, Nov 9, 2020 at 4:10 PM Sean Anderson <seanga2@xxxxxxxxx> wrote: > > On 11/9/20 4:59 PM, Rob Herring wrote: > > On Sat, Nov 07, 2020 at 05:14:03PM +0900, Damien Le Moal wrote: > >> Introduce the dt-bindings file include/dt-bindings/mfd/k210_sysctl.h to > >> define the offset of all registers of the K210 system controller. > > > > We generally don't have defines for registers in DT. > > At least K210_SYSCTL_SOFT_RESET is necessary for the syscon-reboot driver. How does a generic driver need your platform specific define? I meant just use numbers directly. Rob