On Mon, 09 Nov 2020 17:30:09 +0800, Shane Chien wrote: > From: "Shane.Chien" <shane.chien@xxxxxxxxxxxx> > > This patch add "LDO_VAUD18-supply" property to > control vaud18 regulator. It is labeled as required > due to mt6359 audio path always need to enable vaud18. > > Signed-off-by: Shane.Chien <shane.chien@xxxxxxxxxxxx> > --- > .../devicetree/bindings/sound/mt6359.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/mt6359.yaml: properties:LDO_VAUD18-supply: Additional properties are not allowed ('ref' was unexpected) /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/mt6359.yaml: properties:LDO_VAUD18-supply: 'ref' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'type', 'typeSize', 'unevaluatedProperties', 'uniqueItems'] /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/mt6359.yaml: ignoring, error in schema: properties: LDO_VAUD18-supply warning: no schema found in file: ./Documentation/devicetree/bindings/sound/mt6359.yaml See https://patchwork.ozlabs.org/patch/1396618 The base for the patch is generally the last rc1. Any dependencies should be noted. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.