On 09/11/2020 16:17:40+0200, Andy Shevchenko wrote: > > + if (input != bank->is_input) { > > > + dev_err(pctldev->dev, "Pin %d direction as %s is not possible\n", > > + pin, input ? "input" : "output"); > > Do we need this noise? Isn't user space getting a proper error code as > per doc and can handle this? > Why would userspace get the error code? Userspace should never have to handle gpios directly or you are doing something wrong. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com