On Mon, Nov 09, 2020 at 11:16:54AM +0800, Wan Ahmad Zainie wrote: > Add support for USB PHY on Intel Keem Bay SoC. ... > +config PHY_INTEL_KEEMBAY_USB > + tristate "Intel Keem Bay USB PHY driver" > + depends on ARCH_KEEMBAY || (ARM64 && COMPILE_TEST) > + depends on OF && HAS_IOMEM Do you really need dependency to OF (yes, I see that it will be not functional, but still can be compile tested)? > + select GENERIC_PHY > + select REGMAP_MMIO > + help > + Choose this option if you have an Intel Keem Bay SoC. > + > + To compile this driver as a module, choose M here: the module > + will be called phy-keembay-usb.ko. ... > +#include <linux/bitfield.h> > +#include <linux/bits.h> > +#include <linux/clk.h> > +#include <linux/delay.h> > +#include <linux/module.h> > +#include <linux/of.h> No evidence of anything being used in this code. mod_devicetable.h is missed, though. > +#include <linux/phy/phy.h> > +#include <linux/platform_device.h> > +#include <linux/regmap.h> ... > + usleep_range(30, 50); Why 30-50? ... > + usleep_range(20, 50); Why these numbers? ... > + usleep_range(2, 10); Ditto. ... > + usleep_range(20, 50); Ditto. ... > + struct device_node *np = dev->of_node; It's being used only once and it doesn't bring any benefit. -- With Best Regards, Andy Shevchenko
