On Sun, 8 Nov 2020 at 03:23, Nathan Chancellor <natechancellor@xxxxxxxxx> wrote: Hi, Thanks for the fixes. Please mark patches with versions, this should be v2. Otherwise maintainer might apply the older one, You also need to add versioning changelog after ---. > $ make -skj"$(nproc)" ARCH=arm64 CROSS_COMPILE=aarch64-linux- \ > INSTALL_DTBS_PATH=rootfs distclean defconfig dtbs dtbs_install All this is still irrelevant. Just: "make dtbs". Don't add unrelated details like how many processes you spawn, where do you want to install DTBS or even all other make targets. Everyone should know how to cross compile so simple: make dtbs > ... > make[3]: *** No rule to make target > 'rootfs/freescale/imx8mm-kontron-n801x-s.dts', needed by > '__dtbs_install' This should be joined with previous line. I mentioned it in your previous patch. > ... Also not needed dots. This is small change and should go with small and accurate description. Blowing the description does not help. Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> Best regards, Krzysztof
