On 11/5/20, 10:27 AM, Rob Herring wrote: > > On Thu, Nov 5, 2020 at 2:33 AM Marek Szyprowski > <m.szyprowski@xxxxxxxxxxx> wrote: > > > > Hi Rob, > > > > On 04.11.2020 22:35, Rob Herring wrote: > > > On Thu, Oct 29, 2020 at 02:40:13PM +0100, Marek Szyprowski wrote: > > >> Add dt-bindings for the Samsung Exynos PCIe controller (Exynos5433 > > >> variant). Based on the text dt-binding posted by Jaehoon Chung. > > >> > > >> Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> > > >> Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > > >> --- > > >> .../bindings/pci/samsung,exynos-pcie.yaml | 119 ++++++++++++++++++ > > >> 1 file changed, 119 insertions(+) > > >> create mode 100644 Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml > > > > >> ... > > > > >> + num-viewport: > > >> + const: 3 > > > I'm confused why you need this. This is only used with the iATU except > > > for keystone. Platforms like Exynos with their own child bus config > > > space accessors don't have an iATU. > > > > Frankly I have no idea, I don't know much about the PCI internals. > > Sorry, I was confused. It's fine. I was confused, too. But, as far as I remember, I also think that viewpoint-related setting was necessary for Exynos PCIe. Thank you. Best regards, Jingoo Han > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > > Rob
