Re: [PATCH 4/6] arm64: dts: allwinner: pinephone: Add light/proximity sensor

[Maxime Ripard <maxime@xxxxxxxxxx>]

Hi,

On Wed, Nov 04, 2020 at 11:41:33PM -0600, Samuel Holland wrote:
> From: Ondrej Jirman <megous@xxxxxxxxxx>
> 
> Pinephone has STK3311-X proximity sensor. Add support for it.
> 
> Signed-off-by: Ondrej Jirman <megous@xxxxxxxxxx>
> Signed-off-by: Samuel Holland <samuel@xxxxxxxxxxxx>
> ---
>  .../arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> index e595a8262920..9544d7658794 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> @@ -160,6 +160,16 @@ lis3mdl: lis3mdl@1e {
>  		vddio-supply = <&reg_dldo1>;
>  	};
>  
> +	/* Light/proximity sensor */
> +	stk3311@48 {
> +		compatible = "sensortek,stk3311";
> +		reg = <0x48>;
> +		interrupt-parent = <&pio>;
> +		interrupts = <1 0 IRQ_TYPE_EDGE_FALLING>; /* PB0 */
> +		vdd-supply = <&reg_ldo_io0>;
> +		leda-supply = <&reg_dldo1>;
> +	};
> +

The node names should be the class of the device, not the model. The
other sensors here have a similar issue though, so I've applied it, but
could you send a subsequent patch fixing this?

Thanks!
Maxime

Attachment: signature.asc
Description: PGP signature