On 11/3/2020 9:35 AM, Dan Murphy wrote:
> Andrew
>
> On 11/3/20 11:18 AM, Andrew Lunn wrote:
>> On Tue, Nov 03, 2020 at 11:07:00AM -0600, Dan Murphy wrote:
>>> Andrew
>>>
>>> On 10/30/20 3:15 PM, Andrew Lunn wrote:
>>>>> +static int dp83td510_config_init(struct phy_device *phydev)
>>>>> +{
>>>>> + struct dp83td510_private *dp83td510 = phydev->priv;
>>>>> + int mst_slave_cfg;
>>>>> + int ret = 0;
>>>>> +
>>>>> + if (phy_interface_is_rgmii(phydev)) {
>>>>> + if (dp83td510->rgmii_delay) {
>>>>> + ret = phy_set_bits_mmd(phydev, DP83TD510_DEVADDR,
>>>>> + DP83TD510_MAC_CFG_1,
>>>>> dp83td510->rgmii_delay);
>>>>> + if (ret)
>>>>> + return ret;
>>>>> + }
>>>>> + }
>>>> Hi Dan
>>>>
>>>> I'm getting a bit paranoid about RGMII delays...
>>> Not sure what this means.
>> See the discussion and breakage around the realtek PHY. It wrongly
>> implemented RGMII delays. When it was fixed, lots of board broke
>> because the bug in the PHY driver hid bugs in the DT.
>>
> I will have to go find that thread. Do you have a link?
That would be the thread:
https://lore.kernel.org/netdev/CAMj1kXEEF_Un-4NTaD5iUN0NoZYaJQn-rPediX0S6oRiuVuW-A@xxxxxxxxxxxxxx/
--
Florian
