Hi Rob, Thank you for your review! > From: Rob Herring, Sent: Thursday, November 5, 2020 4:05 AM > > On Wed, 04 Nov 2020 16:30:05 +0900, Yoshihiro Shimoda wrote: > > Convert Renesas R-Car USB 2.0 clock selector bindings documentation > > to json-schema. > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > > --- > > .../bindings/clock/renesas,rcar-usb2-clock-sel.txt | 68 -------------- > > .../clock/renesas,rcar-usb2-clock-sel.yaml | 100 +++++++++++++++++++++ > > 2 files changed, 100 insertions(+), 68 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt > > create mode 100644 Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.yaml > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.yaml: > 'additionalProperties' is a required property > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.yaml: ignoring, > error in schema: > warning: no schema found in file: ./Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.yaml I didn't detect these errors because I used dtschema 2020.8.1. As the README.md of dt-schema mentioned like below, I'm thinking I should have used the latest master branch of dt-schema before I run 'make dt_binding_check'. $ pip3 list --user | grep dtschema dtschema 2020.8.1 <dt-schema path> --> This version didn't detect the errors above. $ pip3 list --user | grep dtschema dtschema 2020.8.2.dev11+gf66186d < dt-schema path > --> This version could detect the errors above. I'll fix the errors on v2. Best regards, Yoshihiro Shimoda
