On Wed, Nov 4, 2020 at 4:50 PM Rob Herring <robh@xxxxxxxxxx> wrote:
>
> On Thu, Oct 29, 2020 at 03:59:06PM -0400, Jim Quinlan wrote:
> > Bindings are added. Only one interrupt is needed because
> > we do not yet employ the SCMI p2a channel.
>
> I still don't understand what this is. To repeat from v1: I thought SCMI
> was a mailbox consumer, not provider?
Hi Rob,
I'm not sure where I am implying that SCMI is a mailbox provider?
Should I not mention "SCMI" in the subject line?
This is just a mailbox driver, "consumed" by SCMI. Our SCMI DT node
looks like this:
brcm_scmi_mailbox: brcm_scmi_mailbox@0 {
#mbox-cells = <1>;
compatible = "brcm,brcmstb-mbox";
};
brcm_scmi@0 {
compatible = "arm,scmi";
mboxes = <&brcm_scmi_mailbox 0>;;
mbox-names = "tx";
shmem = <&NWMBOX>;
/* ... */
};
Please advise,
Jim Quinlan
Broadcom STB
>
> >
> > Signed-off-by: Jim Quinlan <james.quinlan@xxxxxxxxxxxx>
> > ---
> > .../bindings/mailbox/brcm,brcmstb-mbox.yaml | 39 +++++++++++++++++++
> > 1 file changed, 39 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/mailbox/brcm,brcmstb-mbox.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/mailbox/brcm,brcmstb-mbox.yaml b/Documentation/devicetree/bindings/mailbox/brcm,brcmstb-mbox.yaml
> > new file mode 100644
> > index 000000000000..797c0cc609a3
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mailbox/brcm,brcmstb-mbox.yaml
> > @@ -0,0 +1,39 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#";
> > +$id: http://devicetree.org/schemas/mailbox/brcm,brcmstb-mbox.yaml#
> > +
> > +title: Broadcom STB mailbox driver bindings
> > +
> > +maintainers:
> > + - Jim Quinlan <james.quinlan@xxxxxxxxxxxx>
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - brcm,brcmstb-mbox
> > +
> > + interrupts:
> > + items:
> > + - description: a2p return interrupt, indicates SCMI msg completion.
> > +
> > + "#mbox-cells":
> > + const: 1
> > +
> > +required:
> > + - compatible
> > + - interrupts
> > + - "#mbox-cells"
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + mailbox {
> > + compatible = "brcm,brcmstb-mailbox";
> > + #mbox-cells = <1>;
> > + interrupts = <GIC_SPI 0xc6 IRQ_TYPE_LEVEL_HIGH>;
> > + };
> > +...
> > --
> > 2.17.1
> >
>
>
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
