> On Wed, 28 Oct 2020 18:55:54 -0400, Khalil Blaiech wrote: > > Write the devicetree binding text file in schema file, JSON > > compatible subset of YAML. > > Besides, add an entry within MAINTAINERS file. > > > > Fixes: d9becc53b3ade81e ("dt-bindings: i2c: I2C binding for Mellanox > BlueField SoC") > > Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxx> > > Signed-off-by: Khalil Blaiech <kblaiech@xxxxxxxxxx> > > --- > > .../bindings/i2c/mellanox,i2c-mlxbf.txt | 42 ---------- > > .../bindings/i2c/mellanox,i2c-mlxbf.yaml | 78 +++++++++++++++++++ > > MAINTAINERS | 1 + > > 3 files changed, 79 insertions(+), 42 deletions(-) > > delete mode 100644 > Documentation/devicetree/bindings/i2c/mellanox,i2c-mlxbf.txt > > create mode 100644 > Documentation/devicetree/bindings/i2c/mellanox,i2c-mlxbf.yaml > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/i2c/mellanox,i2c-mlxbf.yaml:28:7: > [warning] wrong indentation: expected 4 but found 6 (indentation) > ./Documentation/devicetree/bindings/i2c/mellanox,i2c-mlxbf.yaml:31:7: > [warning] wrong indentation: expected 4 but found 6 (indentation) > > dtschema/dtc warnings/errors: > > > See https://patchwork.ozlabs.org/patch/1389582 > > The base for the patch is generally the last rc1. Any dependencies > should be noted. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. Thank you, Rob. Will do.