Re: [PATCH 2/5] ARM: dts: add Samsung's exynos4412-based p4note boards

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Martin,

On 02.11.2020 22:21, Martin Juecker wrote:
> > ...
>>> +
>>> +&fimd {
>>> +	pinctrl-0 = <&lcd_clk &lcd_data24 &pwm1_out>;
>>> +	pinctrl-names = "default";
>>> +	status = "okay";
>>> +
>>> +	display-timings {
>>> +		timing0 {
>>> +			clock-frequency = <66666666>;
>>> +			hactive = <1280>;
>>> +			vactive = <800>;
>>> +			hfront-porch = <18>;
>>> +			hback-porch = <36>;
>>> +			hsync-len = <16>;
>>> +			vback-porch = <16>;
>>> +			vfront-porch = <4>;
>>> +			vsync-len = <3>;
>>> +			hsync-active = <1>;
>>> +		};
>>> +	};
>> What happened with Marek's comment about this?
>>
> Should have mentioned it in the introduction mail. I had a look at the
> simple panel driver and it's not enough for the display in the p4note. I
> asked Marek in IRC whether it's ok to have this in a separate patch set
> to have a fully working display and he agreed.

Yes, I agreed that the display can be added later in a separate patch. 
However in such case I would simply remove the whole fimd node now. 
Without a panel it is a bit useless imho. With a proper panel driver you 
will also get rid of the timings subnode, so there is no point adding it 
now.

Best regards

-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux