Re: [PATCH v3 0/4] Clarify abstract scale usage for power values in Energy Model, EAS and IPA

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 10/19/20 3:05 PM, Lukasz Luba wrote:
Hi all,

The Energy Model supports power values expressed in an abstract scale.
This has an impact on Intelligent Power Allocation (IPA) and should be
documented properly. Kernel sub-systems like EAS, IPA and DTPM
(new comming PowerCap framework) would use the new flag to capture
potential miss-configuration where the devices have registered different
power scales, thus cannot operate together.

There was a discussion below v2 of this patch series, which might help
you to get context of these changes [2].

The agreed approach is to have the DT as a source of power values expressed
always in milli-Watts and the only way to submit with abstract scale values
is via the em_dev_register_perf_domain() API.

Changes:
v3:
- added boolean flag to struct em_perf_domain and registration function
   indicating if EM holds real power values in milli-Watts (suggested by
   Daniel and aggreed with Quentin)
- updated documentation regarding this new flag
- dropped DT binding change for 'sustainable-power'
- added more maintainers on CC (due to patch 1/4 touching different things)
v2 [2]:
- updated sustainable power section in IPA documentation
- updated DT binding for the 'sustainable-power'
v1 [1]:
- simple documenation update with new 'abstract scale' in EAS, EM, IPA

Regards,
Lukasz Luba

[1] https://lore.kernel.org/linux-doc/20200929121610.16060-1-lukasz.luba@xxxxxxx/
[2] https://lore.kernel.org/lkml/20201002114426.31277-1-lukasz.luba@xxxxxxx/

Lukasz Luba (4):
   PM / EM: Add a flag indicating units of power values in Energy Model
   docs: Clarify abstract scale usage for power values in Energy Model
   PM / EM: update the comments related to power scale
   docs: power: Update Energy Model with new flag indicating power scale

  .../driver-api/thermal/power_allocator.rst    | 13 +++++++-
  Documentation/power/energy-model.rst          | 30 +++++++++++++++----
  Documentation/scheduler/sched-energy.rst      |  5 ++++
  drivers/cpufreq/scmi-cpufreq.c                |  3 +-
  drivers/opp/of.c                              |  2 +-
  include/linux/energy_model.h                  | 20 ++++++++-----
  kernel/power/energy_model.c                   | 26 ++++++++++++++--
  7 files changed, 81 insertions(+), 18 deletions(-)



Gentle ping to Quentin and Daniel for sharing opinion on this patch set.
If you are OK, then I could use this as a base for next work.

As you probably know I am working also on 'sustainable power' estimation
which could be used when there is no DT value but it comes from FW.
That would meet requirement from Doug, when the DT cannot be used,
but we have sustainable levels from FW [1].

Regards,
Lukasz

[1] https://lore.kernel.org/lkml/20201028140847.1018-5-lukasz.luba@xxxxxxx/



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux