On Thu, Oct 29, 2020 at 8:55 PM Jun Li <lijun.kernel@xxxxxxxxx> wrote: > > Amelie DELAUNAY <amelie.delaunay@xxxxxx> 于2020年10月30日周五 上午12:52写道： > > > > > > > > On 10/29/20 4:40 PM, Rob Herring wrote: > > > On Thu, Oct 29, 2020 at 10:58:03AM +0100, Amelie Delaunay wrote: > > >> Power operation mode may depends on hardware design, so, add the optional > > >> property power-opmode for usb-c connector to select the power operation > > >> mode capability. > > >> > > >> Signed-off-by: Amelie Delaunay <amelie.delaunay@xxxxxx> > > >> --- > > >> .../bindings/connector/usb-connector.yaml | 18 ++++++++++++++++++ > > >> 1 file changed, 18 insertions(+) > > >> > > >> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml > > >> index 728f82db073d..200d19c60fd5 100644 > > >> --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml > > >> +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml > > >> @@ -93,6 +93,24 @@ properties: > > >> - device > > >> - dual > > >> > > >> + power-opmode: > > > > > > I've acked this version: > > > > > > https://lore.kernel.org/r/20201020093627.256885-2-badhri@xxxxxxxxxx > > That is a different property only for FRS. > > > > > > > > frs is used for Fast Role Swap defined in USB PD spec. > > I understand it allows to get the same information but I'm wondering why > > the property name is limited to -frs- in this case. What about a > > non-power delivery USB-C connector ? > > It's only for FRS, FRS is in the scope of power delivery. > > > > > Moreover, power-opmode property support is already merged in typec class: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/usb/typec/class.c?h=v5.10-rc1&id=12f3467b0d28369d3add7a0deb65fdac9b503c90 > > and stusb160x driver uses it :( > > > > So, do I need to modify stusb160x driver (and bindings) to take into > > account this USB PD specific property? > > Only Type-C w/o PD need this "power-opmode" property, so this > property is still required. Yet we have the same set of values. So there's something common... Rob
