Hello Alexander,
On 10/5/20 10:34 PM, Alexander Dahl wrote:
> The node names for devices using the pwm-leds driver follow a certain
> naming scheme (now). Parent node name is not enforced, but recommended
> by DT project.
>
> DTC arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml
> CHECK arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml
> /home/alex/build/linux/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml: led-rgb: 'led-blue', 'led-green', 'led-red' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
>
> Signed-off-by: Alexander Dahl <post@xxxxxxxxxxx>
Acked-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
But got two questions below:
> ---
>
> Notes:
> v6 -> v7:
> * split up patch (one per sub arch)
> * added actual warnings to commit message
>
> arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> index 5700e6b700d3..25d548cb975b 100644
> --- a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> +++ b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> @@ -36,34 +36,34 @@
> stdout-path = &uart4;
> };
>
> - led-act {
> + led-controller-1 {
> compatible = "gpio-leds";
>
> - led-green {
> + led-1 {
> label = "mc1:green:act";
> gpios = <&gpioa 13 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "heartbeat";
> };
> };
>
> - led-rgb {
> + led-controller-2 {
Is a single RGB LED really a controller?
> compatible = "pwm-leds";
>
> - led-red {
> + led-2 {
Shouldn't this have been led-1 as well or is the numbering "global" ?
> label = "mc1:red:rgb";
> pwms = <&leds_pwm 1 1000000 0>;
> max-brightness = <255>;
> active-low;
> };
>
> - led-green {
> + led-3 {
> label = "mc1:green:rgb";
> pwms = <&leds_pwm 2 1000000 0>;
> max-brightness = <255>;
> active-low;
> };
>
> - led-blue {
> + led-4 {
> label = "mc1:blue:rgb";
> pwms = <&leds_pwm 3 1000000 0>;
> max-brightness = <255>;
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
