On Mon, Oct 26, 2020 at 03:48:30PM +0100, Krzysztof Kozlowski wrote: > On Sat, Oct 24, 2020 at 04:44:18PM +0200, Martin Jücker wrote: (...) > > +&i2c_7 { > > + samsung,i2c-sda-delay = <100>; > > + samsung,i2c-slave-addr = <0x10>; > > + samsung,i2c-max-bus-freq = <400000>; > > + pinctrl-0 = <&i2c7_bus>; > > + pinctrl-names = "default"; > > + status = "okay"; > > + > > + max77686: max77686_pmic@9 { > > + compatible = "maxim,max77686"; > > + interrupt-parent = <&gpx0>; > > + interrupts = <7 IRQ_TYPE_NONE>; > > + pinctrl-0 = <&max77686_irq>; > > + pinctrl-names = "default"; > > + reg = <0x09>; > > + #clock-cells = <1>; > > + > > + voltage-regulators { > > Just "regulators" and no empty line after this. Skip this comment, it's obviously wrong, as the regulator driver and bindings require the exact name "voltage-regulator". Best regards, Krzysztof