Re: [PATCH v2 5/6] pci: dwc: pci-exynos: rework the driver to support Exynos5433 variant

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Jingoo,

On 10/24/20 12:12 PM, Jingoo Han wrote:
> On 10/23/20, 3:58 AM, Marek Szyprowski wrote:
>>
>> From: Jaehoon Chung <jh80.chung@xxxxxxxxxxx>
>>
>> Exynos5440 SoC support has been dropped since commit 8c83315da1cf ("ARM:
>> dts: exynos: Remove Exynos5440"). Rework this driver to support DWC PCIe
>> variant found in the Exynos5433 SoCs.
>>
>> The main difference in Exynos5433 variant is lack of the MSI support
>> (the MSI interrupt is not even routed to the CPU).
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@xxxxxxxxxxx>
>> [mszyprow: reworked the driver to support only Exynos5433 variant,
>> 	   simplified code, rebased onto current kernel code, added
>> 	   regulator support, converted to the regular platform driver,
>> 	   removed MSI related code, rewrote commit message]
>> Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
>> Acked-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>> ---
>>  drivers/pci/controller/dwc/Kconfig      |   3 +-
>>  drivers/pci/controller/dwc/pci-exynos.c | 358 ++++++++++--------------
>>  drivers/pci/quirks.c                    |   1 +
>>  3 files changed, 145 insertions(+), 217 deletions(-)
> 
> [....]
> 
>> diff --git a/drivers/pci/controller/dwc/pci-exynos.c b/drivers/pci/controller/dwc/pci-exynos.c
>> index 242683cde04a..58056fbdc2fa 100644
>> --- a/drivers/pci/controller/dwc/pci-exynos.c
>> +++ b/drivers/pci/controller/dwc/pci-exynos.c
>> @@ -2,26 +2,23 @@
>>  /*
>>   * PCIe host controller driver for Samsung Exynos SoCs
>>   *
>> - * Copyright (C) 2013 Samsung Electronics Co., Ltd.
>> + * Copyright (C) 2013-2020 Samsung Electronics Co., Ltd.
>>   *		https://www.samsung.com
>>   *
>>   * Author: Jingoo Han <jg1.han@xxxxxxxxxxx>
>> + *	   Jaehoon Chung <jh80.chung@xxxxxxxxxxx>
> 
> Would you explain the reason why you add him as an author?
> If reasonable, I will accept it. Also, I want gentle discussion, not aggressive one.
> Thank you.

It's not important to add me as author. :)
If you don't want to accept it, i think it can be removed it.
I think that pci-exynos was supported on only exynos5440.
As you know, exynos5440 was not common as compared with other exynos SoC.
After this patch, pci-exynos is re-newed.

Best Regards,
Jaehoon Chung

> 
> Best regards,
> Jingoo Han
> 
>>   */
> 
> [....]
> 




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux