Re: [PATCH v3 2/5] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



It was <2020-10-23 pią 18:27>, when Krzysztof Kozlowski wrote:
> On Fri, 23 Oct 2020 at 18:05, Rob Herring <robh@xxxxxxxxxx> wrote:
>>
>> On Wed, 21 Oct 2020 23:49:07 +0200, Łukasz Stelmach wrote:
>> > Add bindings for AX88796C SPI Ethernet Adapter.
>> >
>> > Signed-off-by: Łukasz Stelmach <l.stelmach@xxxxxxxxxxx>
>> > ---
>> >  .../bindings/net/asix,ax88796c.yaml           | 69 +++++++++++++++++++
>> >  1 file changed, 69 insertions(+)
>> >  create mode 100644 Documentation/devicetree/bindings/net/asix,ax88796c.yaml
>> >
>>
>>
>> My bot found errors running 'make dt_binding_check' on your patch:
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> ./Documentation/devicetree/bindings/net/asix,ax88796c.yaml: $id:
>> relative path/filename doesn't match actual path or filename
>>         expected:
>> https://protect2.fireeye.com/v1/url?k=b676d09f-eb1194b9-b6775bd0-0cc47a31384a-e1cc7da4db18c501&q=1&e=ea7ae062-8c39-4ee3-82fa-37d28062f086&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fnet%2Fasix%2Cax88796c.yaml%23
>> Documentation/devicetree/bindings/net/asix,ax88796c.example.dts:20:18:
>> fatal error: dt-bindings/interrupt-controller/gpio.h: No such file
>> or directory

Fixed.

> Łukasz,
>
> So you really did not compile/test these patches... It's the second
> build failure in the patchset. All sent patches should at least be
> compiled on the latest kernel, if you cannot test them. However this
> patchset should be testable - Artik5 should boot on mainline kernel

Yes, I messed up a bit. I made moved some code around without changing
it just before sending and I didn't run dt_binding_check. My fault, I am
sorry.

-- 
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux