On Wed, 18 Jun 2014, Javier Martinez Canillas wrote: > Hello Lee, > > Thanks a lot for your feedback. > > On 06/17/2014 11:17 PM, Lee Jones wrote: > >> The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout > >> (LDO) regulators. This patch adds support for all these regulators > >> found on the MAX77802 PMIC and is based on a driver added by Simon > >> Glass to the Chrome OS kernel 3.8 tree. > >> > >> Signed-off-by: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx> > >> --- > >> > >> Changes since v1: > >> - Remove unneeded check if num_regulators != MAX77802_MAX_REGULATORS. > >> - Fix .set_suspend_mode handler comment and split regulators ops for > >> regulators that behave differently. Suggested by Mark Brown. > >> - Use module_platform_driver() instead of having init/exit functions. > >> Suggested by Mark Brown. > >> - Use the new descriptor-based GPIO interface instead of the deprecated > >> integer based GPIO one. Suggested by Mark Brown. > >> - Look for "regulators" child node instead of "voltage-regulators" to be > >> consistent with other PMIC drivers. Suggested by Mark Brown. > >> > >> drivers/mfd/max77802.c | 1 + > > > > Can you remove all of the MFD changes from patches 7, 8 and 9 and > > create new one. That way there's no requirement for any cross > > subsystem messiness. > > > > Sure, Mark already suggested the same and I'll do it on the next version. > > But there still be some cross-subsystem dependency/messiness since the > regulator, clk and rtc drivers include the mfd max77802 headers that are added > in Patch 6. What I should have said was _avoidable_ or _unnecessary_ messiness. > So I guess you should either a) take the whole patch-set through your mfd tree > or b) merge the mfd patches and create an immutable branch that can be pulled by > Mark, Mike and Alessandro. > > I don't know what's the preferred workflow in these cases... That's fine. I'm happy to create shared branches when required. > >> drivers/regulator/Kconfig | 9 + > >> drivers/regulator/Makefile | 1 + > >> drivers/regulator/max77802.c | 701 +++++++++++++++++++++++++++++++++++++++++++ > >> 4 files changed, 712 insertions(+) > >> create mode 100644 drivers/regulator/max77802.c > > > > Best regards, > Javier -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
