On Wed, Jun 18, 2014 at 10:26:16AM +0100, Varka Bhadram wrote: > +static int cc2520_probe(struct spi_device *spi) > +{ > + struct cc2520_private *priv; > + struct pinctrl *pinctrl; > + struct cc2520_platform_data *pdata; > + struct device_node __maybe_unused *np = spi->dev.of_node; > > This looks to be definitely unused rather than __maybe_unused. There are > no other occuences of "np" in this function. > > This macro defined like this. > #define __maybe_unused __attribute__((unused)) Sure, but that's irrelevant. There's absolutely no point in this variable existing at all, and it can simply disappear. Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html